Making RWLock::new const fn #66823
Closed
Making RWLock::new const fn #66823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @KodrAus (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
But I believe we can't remove the box here -- there's a comment on the mutex impl that indicates that the underlying system primitives can't move after creation (https://github.com/rust-lang/rust/blob/master/src/libstd/sync/mutex.rs#L112-L116) -- I suspect the same is true of rwlock, we just aren't documenting that today (though probably should do so). |
|
Thanks for the PR! @Mark-Simulacrum is right though in that the system primitives are required to be boxed up here for safety, so technically exposing the underlying API as safe is actually incorrect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #66806
The only problem I saw was the fact that
sys::RWLockwas on the heap, but I couldn't find any reason why so I removed the Box.If there's a reason why it was boxed that I missed please tell me.
I also didn't see any good reason to put this behind a feature, so if this will be accepted as is it will be instant stable.